Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #97417 "fix azure file secret not found issue" #100563

Merged
merged 1 commit into from Mar 25, 2021
Merged

Revert #97417 "fix azure file secret not found issue" #100563

merged 1 commit into from Mar 25, 2021

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Mar 25, 2021 •
edited by liggitt

This reverts commit 8d43976.

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

The original #97417 change broke inline volumes.

Which issue(s) this PR fixes:

Addresses #99061

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Reverts breaking change to inline AzureFile volumes; referenced secrets are now searched for in the same namespace as the pod as in previous releases.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@msau42
Revert "fix azure file secret not found issue"
9c169a2 
This reverts commit 8d43976.

Change-Id: Iefaa0e76489883830ba1c9bdcbc3101bcc33082c
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 25, 2021
@k8s-ci-robot
Copy link
Contributor

@msau42: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 25, 2021
@msau42
Copy link
Member Author

msau42 commented Mar 25, 2021

/sig storage
/priority critical-urgent

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@msau42
Copy link
Member Author

msau42 commented Mar 25, 2021

/assign @feiskyer @gnufied
cc @liggitt

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 25, 2021
@liggitt
Copy link
Member

liggitt commented Mar 25, 2021

/lgtm

does this also require adjustment to the change made in https://github.com/kubernetes/kubernetes/pull/97877/files#r596900593 ?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2021
@liggitt
Copy link
Member

liggitt commented Mar 25, 2021

/kind regression
/milestone v1.21

undoes a 1.21 regression added in #97417

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 25, 2021
@msau42
Copy link
Member Author

msau42 commented Mar 25, 2021

does this also require adjustment to the change made in https://github.com/kubernetes/kubernetes/pull/97877/files#r596900593 ?

Yes several followups need to be made after this revert:

I think those 2 followups are not as urgent (impacts new functionality vs existing functionality) so I'll let @andyzhangx followup in a future patch release.

@msau42
Copy link
Member Author

msau42 commented Mar 25, 2021

/retest

1 similar comment
@msau42
Copy link
Member Author

msau42 commented Mar 25, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@msau42: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure-file 9c169a2 link /test pull-kubernetes-e2e-aks-engine-azure-file
pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim 9c169a2 link /test pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 01f7495 into kubernetes:master Mar 25, 2021
@palnabarun palnabarun mentioned this pull request Mar 29, 2021
Closed
@andyzhangx andyzhangx mentioned this pull request Apr 14, 2021
Closed
@msau42 msau42 deleted the revert-azure branch July 22, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@gnufied gnufied

@feiskyer feiskyer

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@msau42 @k8s-ci-robot @liggitt @gnufied @feiskyer