New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #97417 "fix azure file secret not found issue" #100563
Conversation
This reverts commit 8d43976. Change-Id: Iefaa0e76489883830ba1c9bdcbc3101bcc33082c
@msau42: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig storage |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm does this also require adjustment to the change made in https://github.com/kubernetes/kubernetes/pull/97877/files#r596900593 ? |
/kind regression undoes a 1.21 regression added in #97417 |
Yes several followups need to be made after this revert:
I think those 2 followups are not as urgent (impacts new functionality vs existing functionality) so I'll let @andyzhangx followup in a future patch release. |
/retest |
1 similar comment
/retest |
@msau42: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This reverts commit 8d43976.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
The original #97417 change broke inline volumes.
Which issue(s) this PR fixes:
Addresses #99061
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: