Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KUBE_BUILD_CONFORMANCE on package-tarballs target #100571

Merged
merged 1 commit into from Mar 26, 2021
Merged

Add KUBE_BUILD_CONFORMANCE on package-tarballs target #100571

merged 1 commit into from Mar 26, 2021

Conversation

puerco
Copy link
Member

@puerco puerco commented Mar 26, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

During the v1.21.0-beta0 and v1.21.0-rc.0 the conformance images were not being created. This PR modifies the Makefile to pass KUBE_BUILD_CONFORMANCE=y to the package-tarballs target to enable building the conformance tarballs.

Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net

Which issue(s) this PR fixes:

Follow up to #100251

Special notes for your reviewer:

Slack ref: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1616708843119100?thread_ts=1616684931.106200&cid=CJH2GBF7Y

Does this PR introduce a user-facing change?

Pass `KUBE_BUILD_CONFORMANCE=y` to the package-tarballs to reenable building the conformance tarballs.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@puerco
Add KUBE_BUILD_CONFORMANCE on package-tarballs target
999a1f5 
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 26, 2021
@k8s-ci-robot
Copy link
Contributor

@puerco: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 26, 2021
@puerco
Copy link
Member Author

puerco commented Mar 26, 2021

/sig release

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 26, 2021
BenTheElder
BenTheElder approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

this is likely the best low-touch / smallest patch for this, but we may need to come back and consider reverting the related change to release.sh (in which case this patch will still be safe & reasonable to have)

@BenTheElder BenTheElder added this to the v1.21 milestone Mar 26, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2021
@BenTheElder BenTheElder added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 26, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 26, 2021
@BenTheElder BenTheElder added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 26, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2021
@BenTheElder BenTheElder added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 26, 2021
hasheddan
hasheddan approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dims
Copy link
Member

dims commented Mar 26, 2021

/approve
/lgtm

@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-kind
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, hasheddan, justaugustus, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9af6f70 into kubernetes:master Mar 26, 2021
@puerco puerco mentioned this pull request Mar 26, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@hasheddan hasheddan hasheddan approved these changes

Assignees

@dims dims

@justaugustus justaugustus

@BenTheElder BenTheElder

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@puerco @k8s-ci-robot @dims @justaugustus @BenTheElder @hasheddan