Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed kubectl describe ingress causing SEGFAULT if API Group is not specified #100505

Merged
merged 1 commit into from Mar 24, 2021
Merged

Fixed kubectl describe ingress causing SEGFAULT if API Group is not specified #100505

merged 1 commit into from Mar 24, 2021

Conversation

lauchokyip
Copy link
Member

@lauchokyip lauchokyip commented Mar 23, 2021 •
edited by liggitt

What type of PR is this?

/kind bug

What this PR does / why we need it:

When using kubectl describe ingress on this YAML file, it causes SEGFAULT

cat <<EOF | kubectl apply -f -
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: test
spec:
  rules:
  - host: example.com
    http:
      paths:
      - pathType: Prefix
        path: /
        backend:
          resource:
            kind: PersistentVolumeClaim
            name: TestClaim
EOF

kubectl describe ing test

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1030

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubectl: Fixes a regression in 1.19+ describing an ingress backend without an API Group

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lauchokyip. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2021
@lauchokyip lauchokyip closed this Mar 23, 2021
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 23, 2021
@lauchokyip lauchokyip reopened this Mar 23, 2021
@lauchokyip
Copy link
Member Author

/cc @rikatz

@rikatz
Copy link
Contributor

rikatz commented Mar 23, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2021
soltysh
soltysh approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/priority backlog
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 24, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lauchokyip, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@eddiezane
Copy link
Member

@kubernetes/release-team-leads @palnabarun for approval since this fixes a nil-pointer

I'll also open cherrypicks

@soltysh
Copy link
Contributor

soltysh commented Mar 24, 2021

Adding this to 1.21 since this is fixing a nil-pointer problem.
/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit e71e284 into kubernetes:master Mar 24, 2021
This was referenced Mar 24, 2021
Merged
Merged
@eddiezane
Copy link
Member

@lauchokyip can you please edit your top level comment and add the following release note?

kubectl: Fixed panic when describing an ingress backend without an API Group

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 24, 2021
@soltysh
Copy link
Contributor

soltysh commented Mar 24, 2021

@eddiezane fixed 😉

@lauchokyip
Copy link
Member Author

Thank you @soltysh and @eddiezane !

@lauchokyip lauchokyip deleted the fixDescribe branch March 24, 2021 21:33
k8s-ci-robot added a commit that referenced this pull request Mar 25, 2021
@k8s-ci-robot
Merge pull request #100542 from eddiezane/automated-cherry-pick-of-#1…
819643c 
…00505-upstream-release-1.19

Automated cherry pick of #100505: Fixed describe ingress causing SEGFAULT
k8s-ci-robot added a commit that referenced this pull request Mar 25, 2021
@k8s-ci-robot
Merge pull request #100541 from eddiezane/automated-cherry-pick-of-#1…
5ec39ba 
…00505-upstream-release-1.20

Automated cherry pick of #100505: Fixed describe ingress causing SEGFAULT
@github-actions github-actions bot mentioned this pull request Apr 5, 2021
Open
@lauchokyip lauchokyip mentioned this pull request Apr 9, 2021
Closed
6 tasks
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

@rikatz rikatz Awaiting requested review from rikatz

@eddiezane eddiezane Awaiting requested review from eddiezane

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

SEGFAULT: describe ingress with backend.resource
6 participants
@lauchokyip @k8s-ci-robot @rikatz @eddiezane @soltysh @liggitt