Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiserver add --lease-reuse-duration-seconds to config lease reuse duration #97009

Merged
merged 1 commit into from Dec 9, 2020
Merged

apiserver add --lease-reuse-duration-seconds to config lease reuse duration #97009

merged 1 commit into from Dec 9, 2020

Conversation

lingsamuel
Copy link
Contributor

@lingsamuel lingsamuel commented Dec 2, 2020 •
edited

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Details in #96836

Which issue(s) this PR fixes:

Part of #96836

Special notes for your reviewer:

Do we need to config leaseReuseDurationPercent too?

Does this PR introduce a user-facing change?:

Add flag --lease-reuse-duration-seconds for kube-apiserver to config etcd lease reuse duration.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @lingsamuel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 2, 2020
@lingsamuel
Copy link
Contributor Author

/sig scalability

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 2, 2020
@lingsamuel
Copy link
Contributor Author

/cc @mborsz

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Dec 2, 2020
lingsamuel
lingsamuel commented Dec 2, 2020
View reviewed changes
staging/src/k8s.io/apiserver/pkg/storage/etcd3/lease_manager.go
func newDefaultLeaseManager(client *clientv3.Client) *leaseManager {
return newLeaseManager(client, 60, 0.05)
func newDefaultLeaseManager(client *clientv3.Client, leaseReuseDurationSeconds int64) *leaseManager {
return newLeaseManager(client, leaseReuseDurationSeconds, 0.05)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change this to an option struct if we can config a max size of a lease further.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that when we will be adding the next argument.

@fedebongio
Copy link
Contributor

/assign @wojtek-t @jingyih
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 3, 2020
wojtek-t
wojtek-t reviewed Dec 4, 2020
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just some minor comments.

/ok-to-test

staging/src/k8s.io/apiserver/pkg/server/options/etcd.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/etcd3/lease_manager.go
func newDefaultLeaseManager(client *clientv3.Client) *leaseManager {
return newLeaseManager(client, 60, 0.05)
func newDefaultLeaseManager(client *clientv3.Client, leaseReuseDurationSeconds int64) *leaseManager {
return newLeaseManager(client, leaseReuseDurationSeconds, 0.05)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that when we will be adding the next argument.

staging/src/k8s.io/apiserver/pkg/server/options/etcd.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2020
@lingsamuel lingsamuel changed the title apiserver add --etcd-lease-reuse-duration to config lease reuse duration apiserver add --lease-reuse-duration-seconds to config lease reuse duration Dec 4, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Dec 4, 2020

@lingsamuel - please fix bazel (you need to autogenerate them) and I will approve once tests are green.

@lingsamuel lingsamuel force-pushed the etcd-config-reuse-duration branch 3 times, most recently from 1d14d08 to 701d57b Compare December 4, 2020 11:13
@lingsamuel
apiserver add --lease-reuse-duration-seconds to config lease reuse du…
c995670 
…ration

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@wojtek-t
Copy link
Member

wojtek-t commented Dec 4, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingsamuel, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@wojtek-t wojtek-t added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 4, 2020
@mborsz
Copy link
Member

mborsz commented Dec 7, 2020

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot merged commit 74b4f3d into kubernetes:master Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 9, 2020
@lingsamuel lingsamuel deleted the etcd-config-reuse-duration branch December 10, 2020 05:49
@github-actions github-actions bot mentioned this pull request Dec 16, 2020
Open
@lingsamuel lingsamuel mentioned this pull request Jan 8, 2021
Merged
@mborsz mborsz mentioned this pull request Mar 10, 2021
Merged
This was referenced Mar 22, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@timothysc timothysc Awaiting requested review from timothysc

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mborsz mborsz

@wojtek-t wojtek-t

@jingyih jingyih

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lingsamuel @k8s-ci-robot @fedebongio @wojtek-t @mborsz @jingyih