Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick #96876 in controller to 1.19: fix nodelifecyle controller not add NoExecute taint bug #98140

Merged
merged 1 commit into from Mar 5, 2021
Merged

Cherry pick #96876 in controller to 1.19: fix nodelifecyle controller not add NoExecute taint bug #98140

merged 1 commit into from Mar 5, 2021

Conversation

CKchen0726
Copy link
Contributor

@CKchen0726 CKchen0726 commented Jan 18, 2021 •
edited by liggitt

What type of PR is this?
/kind bug

What this PR does / why we need it:
this PR #89059 try to fix reconcile problem, so every 5s monitorNodeHealth() run processTaintBaseEviction(), add nodes to zoneNoExecuteTainter cause these nodes' status is Unknown or False.
Ref: #96876

Which issue(s) this PR fixes:
Fix: #94183 #96183

Special notes for your reviewer:
I write a helper func to print values inside RateLimitedTimedQueue, and unit test running log as below, and log display the dirty data inside queue field.

Does this PR introduce a user-facing change?

fixing a regression in 1.19+ where a failed node may not have the NoExecute taint set correctly

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 18, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jan 18, 2021
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @CKchen0726. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 18, 2021
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 18, 2021
@JornShen JornShen mentioned this pull request Jan 19, 2021
Closed
@JornShen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 19, 2021
@JornShen
Copy link
Member

/cc @derekwaynecarr @Huang-Wei @k82cn

@k8s-ci-robot @CKchen0726
Merge pull request kubernetes#96876 from howieyuen/no-execute-taint-m…
958c54c 
…issing

fix nodelifecyle controller not add NoExecute taint bug
@CKchen0726
Copy link
Contributor Author

/retest

@CKchen0726
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@adampl adampl mentioned this pull request Jan 21, 2021
Closed
@PhanLe1010 PhanLe1010 mentioned this pull request Jan 29, 2021
Closed
@adampl
Copy link

adampl commented Feb 5, 2021

@smarterclayton @Huang-Wei @gmarek @derekwaynecarr @k82cn please approve, it's critical

@k82cn
Copy link
Member

k82cn commented Feb 8, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 8, 2021
@Huang-Wei
Copy link
Member

cc @kubernetes/release-managers

ehashman
ehashman approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/priority important-soon
/triage accepted
/lgtm
/sig node

I'm going to try to get all three branches lined up.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 23, 2021
@ehashman ehashman added this to Done in SIG Node PR Triage Feb 23, 2021
@LuckySB
Copy link

LuckySB commented Mar 5, 2021

@hasheddan can you add cherry-pick-approved label ?

@LuckySB
Copy link

LuckySB commented Mar 5, 2021

/assign @hasheddan

hasheddan
hasheddan approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CKchen0726, ehashman, hasheddan, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit a0b7423 into kubernetes:release-1.19 Mar 5, 2021
This was referenced May 19, 2021
Closed
Closed
@ingvagabund ingvagabund mentioned this pull request Oct 4, 2021
Closed
@CKchen0726 CKchen0726 deleted the cherry-pick-96876-1.19 branch October 25, 2021 07:51
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
@harder-worker
Copy link

How can this phenomenon be reproduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman approved these changes

@hasheddan hasheddan hasheddan approved these changes

@gmarek gmarek Awaiting requested review from gmarek

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@Huang-Wei Huang-Wei

@ehashman ehashman

@k82cn k82cn

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet