Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated pkg/proxy/userspace to structured logging #104931

Merged
merged 4 commits into from Sep 13, 2021
Merged

Migrated pkg/proxy/userspace to structured logging #104931

merged 4 commits into from Sep 13, 2021

Conversation

shiva1333
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate pkg/proxy/userspace to structured logging

Which issue(s) this PR fixes:

Fixes #
Ref #104872

Special notes for your reviewer:

Does this PR introduce a user-facing change?

migrated pkg/proxy/userspace to structured logging

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 11, 2021
@k8s-ci-robot
Copy link
Contributor

@shivanshu1333: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @shivanshu1333. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 11, 2021
@shiva1333 shiva1333 changed the title Migrated pkg/proxy/userspace to structured Migrated pkg/proxy/userspace to structured logging Sep 11, 2021
@shiva1333 shiva1333 mentioned this pull request Sep 11, 2021
Closed
thockin
thockin reviewed Sep 11, 2021
View reviewed changes
pkg/proxy/userspace/proxysocket.go Outdated
return nil, err
}
klog.V(3).Infof("Mapped service %q to endpoint %s", service, endpoint)
klog.V(3).InfoS("Mapped service to endpoint", "serivce", service, "endpoint", endpoint)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misspelled "service'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, my bad, thanks for pointing out, fixed

@thockin thockin added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2021
thockin
thockin reviewed Sep 12, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 12, 2021
@shiva1333
Copy link
Contributor Author

/test pull-kubernetes-verify

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@shiva1333
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 13, 2021
@serathius serathius moved this from Inbox to Waiting on Author in WG Structured Logging - 1.23 Migration Sep 13, 2021
@shiva1333 shiva1333 force-pushed the pkg-proxy-userspace-structured-logging-migration branch from 7eb6a79 to de8652d Compare September 13, 2021 10:01
@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 13, 2021
@shiva1333 shiva1333 force-pushed the pkg-proxy-userspace-structured-logging-migration branch from 1228630 to 1471319 Compare September 13, 2021 10:08
@shiva1333
Copy link
Contributor Author

Work done after receiving lgtm label:

  1. Squashed typo fix commit
  2. code formatting done using ./hack/update-gofmt.sh

@shiva1333 shiva1333 force-pushed the pkg-proxy-userspace-structured-logging-migration branch from 1471319 to 7eb6a79 Compare September 13, 2021 11:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Sep 13, 2021
@shiva1333
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2021
@shiva1333
Copy link
Contributor Author

shiva1333 commented Sep 13, 2021 •
edited

@thockin can you please re add the lgtm label?

Work done after receiving lgtm label:

  1. Squashed typo fix commit
  2. code formatting done using ./hack/update-gofmt.sh

There is no additional change, thanks!

@serathius serathius moved this from Waiting on Author to Waiting on Reviewer in WG Structured Logging - 1.23 Migration Sep 13, 2021
@thockin
Copy link
Member

thockin commented Sep 13, 2021

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shivanshu1333, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4916b6c into kubernetes:master Sep 13, 2021
WG Structured Logging - 1.23 Migration automation moved this from Waiting on Reviewer to Done Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 13, 2021
@shiva1333 shiva1333 mentioned this pull request Sep 15, 2021
Merged
@shiva1333 shiva1333 deleted the pkg-proxy-userspace-structured-logging-migration branch September 15, 2021 17:35
@ccampo133 ccampo133 mentioned this pull request Sep 16, 2021
Closed
@shiva1333 shiva1333 mentioned this pull request Sep 22, 2021
Closed
7 tasks
ibabou pushed a commit to ibabou/kubernetes that referenced this pull request Sep 28, 2021
@shiva1333 @ibabou
Migrated pkg/proxy/userspace to structured logging (kubernetes#104931)
d1968c3 
* migrated roundrobin.go

* migrated proxysocket.go

* fixed typo

* code formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
WG Structured Logging - 1.23 Migration
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shiva1333 @k8s-ci-robot @k8s-triage-robot @pacoxu @serathius @thockin