Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename apiserver_storage_object_counts to apiserver_storage_objects #100082

Merged
merged 1 commit into from Mar 12, 2021
Merged

rename apiserver_storage_object_counts to apiserver_storage_objects #100082

merged 1 commit into from Mar 12, 2021

Conversation

logicalhan
Copy link
Member

@logicalhan logicalhan commented Mar 10, 2021 •
edited

To conform to instrumentation best practices.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Pluralized _counts is actually an anti-pattern for metrics, instead we pluralize the name of the thing being counted for gauges.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

`apiserver_storage_objects` (a newer version of `etcd_object_counts) is promoted and marked as stable.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1209-metrics-stability

@logicalhan
rename apiserver_storage_object_counts to conform to best practices (…
50e6f15 
…apiserver_storage_objects)

Change-Id: I8c08a37cd3ed7c943a6691185f750e55d389dd3a
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2021
@logicalhan
Copy link
Member Author

/sig instrumentation
/cc @erain
/triage accepted
/priority important-soon
/milestone v1.21

@k8s-ci-robot k8s-ci-robot requested a review from erain March 10, 2021 12:37
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 10, 2021
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 10, 2021
@brancz
Copy link
Member

brancz commented Mar 10, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@logicalhan
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2021
@logicalhan
Copy link
Member Author

/retest

erain
erain approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@erain erain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks!!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, erain, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ehashman
Copy link
Member

Are we just waiting on the exception request approval to remove the hold?

@logicalhan
Copy link
Member Author

Are we just waiting on the exception request approval to remove the hold?

yes.

@palnabarun
Copy link
Member

/milestone v1.21

Putting back the milestone since the exception request was APPROVED. ref: https://groups.google.com/g/kubernetes-sig-release/c/p9E6s14269M/m/f0L7VhbeAgAJ

@ehashman
Copy link
Member

/hold cancel

https://groups.google.com/g/kubernetes-sig-release/c/p9E6s14269M/m/2V8WoebdAgAJ

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 019c892 into kubernetes:master Mar 12, 2021
@istvanballok istvanballok mentioned this pull request Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erain erain erain approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@logicalhan @brancz @k8s-ci-robot @ehashman @palnabarun @fejta-bot @erain