JobDeletionDurationSeconds metric in TTLAfterFinished controller #98676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
size/M
|
/remove-kind api-change |
k8s-ci-robot
removed
the
kind/api-change
|
/assign @soltysh |
|
/assign @janetkuo |
ahg-g
force-pushed
the
ahg-ttl
branch
2 times, most recently
from
a0be7db
to
ab069ff
Compare
|
/retest |
k8s-ci-robot
removed
the
size/M
k8s-ci-robot
added
triage/accepted
soltysh
requested changes
Feb 10, 2021
ahg-g
force-pushed
the
ahg-ttl
branch
2 times, most recently
from
06a3830
to
c744af1
Compare
k8s-ci-robot
added
lgtm
dashpole
reviewed
Feb 12, 2021
| TimeToDeletionSeconds = metrics.NewHistogram( | ||
| &metrics.HistogramOpts{ | ||
| Subsystem: TTLAfterFinishedSubsystem, | ||
| Name: "time_to_deletion_seconds", |
There was a problem hiding this comment.
generally durations have the suffix _duration_seconds, such as http_request_duration_seconds, or scheduling_duration_seconds. This is to distinguish them from timestamps (e.g. process_start_time_seconds).
The prefix is up to you, but time_to_deletion_duration_seconds sounds a bit odd. Maybe deletion_duration_seconds, or job_deletion_duration_seconds?
There was a problem hiding this comment.
thanks, changed to job_deletion_duration_seconds
k8s-ci-robot
removed
the
lgtm
ahg-g
changed the title
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, dashpole, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Huang-Wei
reviewed
Feb 12, 2021
| }, | ||
| { | ||
| name: "Job failed 10s ago, 15s TTL", | ||
| failedTime: metav1.NewTime(now.Add(-10 * time.Second)), | ||
| ttl: utilpointer.Int32Ptr(15), | ||
| since: &now.Time, | ||
| expectedTimeLeft: durationPointer(5), | ||
| expectedExpireAt: now.Add(5 * time.Second), | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| job := newJob(tc.completionTime, tc.failedTime, tc.ttl) |
There was a problem hiding this comment.
Off the logic, but we may migrate this to a pure subtest style.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a metric to track the time it took to delete a job by the ttl-after-finished controller.
Which issue(s) this PR fixes:
Part of kubernetes/enhancements#592
Special notes for your reviewer:
This is a requirement to graduate TTLAfterFinished to Beta: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/592-ttl-after-finish#monitoring-requirements
Does this PR introduce a user-facing change?: