Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Cluster Autoscaler to v1.20.0 #97011

Merged
merged 1 commit into from Dec 9, 2020
Merged

Bump Cluster Autoscaler to v1.20.0 #97011

merged 1 commit into from Dec 9, 2020

Conversation

towca
Copy link
Contributor

@towca towca commented Dec 2, 2020 •
edited by liggitt

/kind bug

## Changelog

### General
* Fix priority expander falling back to a random choice even though there is a higher priority option to choose
* Clone `kubernetes/kubernetes` in `update-vendor.sh` shallowly, instead of fetching all revisions
* Speed up binpacking by reducing the number of PreFilter calls (call once per pod instead of #pods*#nodes times)
* Speed up finding unneeded nodes by 5x+ in very large clusters by reducing the number of PreFilter calls
* Expose `--max-nodes-total` as a metric
* Errors in `IncreaseSize` changed fromt type `apiError` to `cloudProviderError`
* Make `build-in-docker` and `test-in-docker` work on Linux systems with SELinux enabled
* Fix an error where existing nodes were not considered as destinations while finding place for pods in scale-down simulations
* Remove redundant log lines and reduce severity around parsing kubeEnv
* Don't treat nodes created by virtual kuebelet as nodes from non-autoscaled node groups
* Remove redundant logging around calculating node utilization
* Add configurable `--network` and `--rm` flags for docker in `Makefile`
* Substract DaemonSet pods' requests from node allocatable in the denominator while computing node utilization
* Include taints by condition when determining if a node is unready/still starting
* Fix `update-vendor.sh` to work on OSX and zsh
* Add best-effort eviction for DaemonSet pods while scaling down non-empty nodes
* Add build support for ARM64

### AliCloud
* Add missing daemonsets and replicasets to ALI example cluster role

### Apache CloudStack
* Add support for Apache CloudStack

### AWS
* Regenerate list of EC2 instances
* Fix pricing endpoint in AWS China Region

### Azure
* Add optional jitter on initial VMSS VM cache refresh, keep the refreshes spread over time
* Serve from cache for the whole period of ongoing throttling
* Fix unwanted VMSS VMs cache invalidations
* Enforce setting the number of retries if cloud provider backoff is enabled
* Don't update capacity if VMSS provisioning state is updating
* Support allocatable resources overrides via VMSS tags
* Add missing stable labels in template nodes
* Proactively set instance status to deleting on node deletions

### Cluster API
* Migrate interaction with the API from using internal types to using Unstructured
* Improve tests to work better with constrained resources
* Add support for node autodiscovery
* Add support for `--cloud-config`
* Update group identifier to use for Cluster API annotations

### Exoscale
* Add support for Exoscale

### GCE
* Decrease the number of GCE Read Requests made while deleting nodes
* Base pricing of custom instances on their instance family type
* Add pricing information for missing machine types
* Add pricing information for different GPU types
* Ignore the new `topology.gke.io/zone` label when comparing groups
* Add missing stable labels to template nodes

### HuaweiCloud
* Add auto scaling group support
* Implement node group by AS
* Implement getting desired instance number of node group
* Implement increasing node group size
* Implement TemplateNodeInfo
* Implement caching instances

### IONOS
* Add support for IONOS

### Kubemark
* Skip non-kubemark nodes while computing node infos for node groups.

### Magnum
* Add Magnum support in the Cluster Autoscaler helm chart

### Packet
* Allow empty nodepools
* Add support for multiple nodepools
* Add pricing support

## Image
Image: `k8s.gcr.io/autoscaling/cluster-autoscaler:v1.20.0`

cluster autoscaler updated to v1.20.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 2, 2020
@k8s-ci-robot
Copy link
Contributor

@towca: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 2, 2020
@towca
Copy link
Contributor Author

towca commented Dec 2, 2020

/assign @MaciekPytel

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 2, 2020
mwielgus
mwielgus approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@towca
Copy link
Contributor Author

towca commented Dec 2, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

7 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

17 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

@towca: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gci-gce-autoscaling 9efbd91 link /test pull-kubernetes-e2e-gci-gce-autoscaling

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 7b4fc68 into kubernetes:master Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 9, 2020
@liggitt liggitt mentioned this pull request Dec 9, 2020
Merged
@github-actions github-actions bot mentioned this pull request Dec 16, 2020
Open
@wilsonehusin
Copy link
Contributor

@towca hello from 1.21 release notes team! We're collecting release notes from each PR and this PR has all the codeblock included in the description as release notes, which isn't helpful when reading the the compiled release notes for the whole 1.21 release. For reference, using the PR template will ensure the release notes gets parsed appropriately.

I have manually overwritten this PR with the release note: "Cluster Autoscaler version bump to v1.20.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@cjcullen cjcullen Awaiting requested review from cjcullen

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@MaciekPytel MaciekPytel

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@towca @k8s-ci-robot @fejta-bot @wilsonehusin @mwielgus @MaciekPytel