Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn on CSIMigrationAzureDisk by default on 1.23 #104670

Merged
merged 1 commit into from Sep 16, 2021
Merged

turn on CSIMigrationAzureDisk by default on 1.23 #104670

merged 1 commit into from Sep 16, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

turn on CSIMigrationAzureDisk by default on 1.23

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted

Does this PR introduce a user-facing change?

turn on CSIMigrationAzureDisk by default on 1.23

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

turn on CSIMigrationAzureDisk by default on 1.23

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Aug 31, 2021
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss
/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim

@Jiawei0227
Copy link
Contributor

I think we might need to migrate the CI to cloud-provider-azure or install the azuredisk csi driver by default.

@andyzhangx
Copy link
Member Author

I think we might need to migrate the CI to cloud-provider-azure or install the azuredisk csi driver by default.

@Jiawei0227 yes, I will fix it later

@andyzhangx andyzhangx mentioned this pull request Sep 6, 2021
Closed
@andyzhangx
Copy link
Member Author

one related PR: kubernetes/test-infra#23487

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-file

1 similar comment
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-file

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-disk

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-file

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-disk

@Jiawei0227
Copy link
Contributor

/retest

@Jiawei0227
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2021
@Jiawei0227
Copy link
Contributor

Seems on windows side it still need some setting?

@andyzhangx
Copy link
Member Author

Seems on windows side it still need some setting?

@Jiawei0227 that's windows test issue, I am still fixing it, need more time.

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss

@andyzhangx andyzhangx mentioned this pull request Sep 12, 2021
Merged
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim

2 similar comments
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim

@andyzhangx andyzhangx changed the title [WIP]turn on CSIMigrationAzureDisk by default on 1.23 turn on CSIMigrationAzureDisk by default on 1.23 Sep 13, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2021
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim
/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss

@andyzhangx andyzhangx mentioned this pull request Sep 13, 2021
Merged
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim

@andyzhangx
Copy link
Member Author

finally, I have fixed all tests with csi driver enabled, could you approve? thanks.
@smarterclayton

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-file-vmss

@andyzhangx
Copy link
Member Author

/retest

@Jiawei0227
Copy link
Contributor

@msau42 for approval.
cc @jsafrane @xing-yang

@andyzhangx andyzhangx mentioned this pull request Sep 14, 2021
Merged
@jsafrane
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5d7ac70 into kubernetes:master Sep 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 16, 2021
@olemarkus olemarkus mentioned this pull request Sep 30, 2021
Closed
3 tasks
@reylejano reylejano mentioned this pull request Nov 15, 2021
Closed
2 tasks
@carlory carlory mentioned this pull request Jan 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

Assignees

@Jiawei0227 Jiawei0227

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyzhangx @Jiawei0227 @jsafrane @k8s-ci-robot