Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SupportPodPidsLimit and SupportNodePidsLimit feature gates #104163

Merged
merged 1 commit into from Sep 20, 2021
Merged

Remove SupportPodPidsLimit and SupportNodePidsLimit feature gates #104163

merged 1 commit into from Sep 20, 2021

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Aug 5, 2021 •
edited

/kind cleanup
/sig node
/priority backlog

Does this PR introduce a user-facing change?

The `SupportPodPidsLimit` and  `SupportNodePidsLimit` feature gates that are GA since v1.20 are unconditionally enabled, and can no longer be specified via the `--feature-gates` argument.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/757
- [Usage]: https://kubernetes.io/docs/concepts/policy/pid-limiting/

@ialidzhikov
Remove SupportPodPidsLimit and SupportNodePidsLimit feature gates
b5d18f1 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ialidzhikov
Copy link
Contributor Author

/cc @dims @derekwaynecarr @RobertKrawitz

@ehashman ehashman added this to Triage in SIG Node PR Triage Aug 5, 2021
neolit123
neolit123 reviewed Aug 6, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please link in the OP to any tracking issues in kubernetes/kubernetes or kubernetes/enhancements.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2021
@ehashman
Copy link
Member

ehashman commented Aug 6, 2021

/triage accepted

please add related KEPs to original comment and I'll review

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 6, 2021
@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Aug 6, 2021
@ialidzhikov
Copy link
Contributor Author

please add related KEPs to original comment and I'll review

Done.

neolit123
neolit123 reviewed Aug 10, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
as per the timeline of the FGs.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
@ialidzhikov
Copy link
Contributor Author

ping @ehashman
for approval

@pacoxu pacoxu moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Aug 17, 2021
@ialidzhikov
Copy link
Contributor Author

ping @dims @derekwaynecarr @RobertKrawitz
for approval

@RobertKrawitz
Copy link
Contributor

ping @dims @derekwaynecarr @RobertKrawitz
for approval

I'm no longer involved in this area so my approval should not be required.

RobertKrawitz
RobertKrawitz approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@RobertKrawitz RobertKrawitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro forma approval, as I'm no longer involved in this area.

@ialidzhikov
Copy link
Contributor Author

👀

@ialidzhikov
Copy link
Contributor Author

/cc @ehashman

@neolit123
Copy link
Member

/milestone v1.23
/unassign

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 13, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Sep 13, 2021
@pacoxu
Copy link
Member

pacoxu commented Sep 17, 2021

/assign derekwaynecarr dchen1107
for approval from sig node feature approvers

ehashman
ehashman reviewed Sep 20, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, ialidzhikov, mrunalp, RobertKrawitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit e8653fe into kubernetes:master Sep 20, 2021
@ingvagabund ingvagabund mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@ehashman ehashman ehashman left review comments

@mrunalp mrunalp mrunalp approved these changes

@RobertKrawitz RobertKrawitz RobertKrawitz approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dims dims Awaiting requested review from dims

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@ehashman ehashman

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ialidzhikov @k8s-ci-robot @ehashman @RobertKrawitz @neolit123 @pacoxu @mrunalp @derekwaynecarr @dchen1107