Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake ingress e2e updates #98430

Merged
merged 1 commit into from Jan 27, 2021
Merged

Deflake ingress e2e updates #98430

merged 1 commit into from Jan 27, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 26, 2021 •
edited

What type of PR is this?

/kind flake

What this PR does / why we need it:

When an Ingress controller is present, it can update the object asynchronously. The e2e test that does an update and status update must be prepared to retry on a conflict error if encountered.

Does this PR introduce a user-facing change?:

Resolves flakes in the Ingress conformance tests due to conflicts with controllers updating the Ingress object

/cc @johnbelamaric @bowei
/sig network

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. labels Jan 26, 2021
@k8s-ci-robot
Copy link
Contributor

@liggitt: The label(s) sig/networking cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind flake

What this PR does / why we need it:

When an Ingress controller is present, it can update the object asynchronously. The e2e test that does an update and status update must be prepared to retry on a conflict error if encountered.

Does this PR introduce a user-facing change?:

Resolves flakes in the Ingress conformance tests due to conflicts with controllers updating the Ingress object

/cc @johnbelamaric @bowei
/sig networking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 26, 2021
@k8s-ci-robot
Copy link
Contributor

@liggitt: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 26, 2021
@liggitt liggitt added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jan 26, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 26, 2021
@bowei
Copy link
Member

bowei commented Jan 26, 2021

/lgtm

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2021
This was referenced Jan 26, 2021
Merged
Merged
@liggitt
Copy link
Member Author

liggitt commented Jan 26, 2021

thanks, picked to 1.19 and 1.20 since this flake impacts conformance test runs

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt
Copy link
Member Author

liggitt commented Jan 26, 2021

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Jan 27, 2021

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 15252db into kubernetes:master Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 27, 2021
k8s-ci-robot added a commit that referenced this pull request Jan 29, 2021
@k8s-ci-robot
Merge pull request #98442 from liggitt/automated-cherry-pick-of-#9843…
66aa787 
…0-upstream-release-1.20

Automated cherry pick of #98430: Deflake ingress updates
k8s-ci-robot added a commit that referenced this pull request Jan 29, 2021
@k8s-ci-robot
Merge pull request #98443 from liggitt/automated-cherry-pick-of-#9843…
bb90e6f 
…0-upstream-release-1.19

Automated cherry pick of #98430: Deflake ingress updates
@liggitt liggitt deleted the ingress-flake branch February 2, 2021 13:23
@github-actions github-actions bot mentioned this pull request Feb 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @bowei @fejta-bot