Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the TokenRequest and TokenRequestProjection feature gates #97148

Merged
merged 1 commit into from Jan 14, 2021
Merged

remove the TokenRequest and TokenRequestProjection feature gates #97148

merged 1 commit into from Jan 14, 2021

Conversation

wawa0210
Copy link
Contributor

@wawa0210 wawa0210 commented Dec 9, 2020 •
edited by liggitt

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

part of #97148

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The GA TokenRequest and TokenRequestProjection feature gates have been removed and are unconditionally enabled. Remove explicit use of those feature gates in CLI invocations.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 9, 2020
@k8s-ci-robot
Copy link
Contributor

@wawa0210: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 9, 2020
@k8s-ci-robot
Copy link
Contributor

@wawa0210: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 9, 2020
@wawa0210
Copy link
Contributor Author

wawa0210 commented Dec 9, 2020

/sig node
/area kubelet

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/kubelet and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 9, 2020
@pacoxu
Copy link
Member

pacoxu commented Dec 9, 2020

Should we do a cleanup in e2e test code as well?
Refer to

kubernetes/test/e2e/auth/service_accounts.go

Lines 422 to 426 in 3af376d

/*
Release : v1.20
Testname: TokenRequestProjection should mount a projected volume with token using TokenRequest API.
Description: Ensure that projected service account token is mounted.
*/

@wawa0210
Copy link
Contributor Author

Should we do a cleanup in e2e test code as well?

kubernetes/test/e2e/auth/service_accounts.go

Lines 422 to 426 in 3af376d

/*
Release : v1.20
Testname: TokenRequestProjection should mount a projected volume with token using TokenRequest API.
Description: Ensure that projected service account token is mounted.
*/

This test still works normally. These two feature gates are moved from beta to GA. The functions work by default. They just cannot be enabled through kubelet.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 10, 2020
@wawa0210
Copy link
Contributor Author

wawa0210 commented Dec 17, 2020 •
edited

/assign @quinton-hoole

Can you help review this pr?

@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Jan 6, 2021
@ehashman
Copy link
Member

ehashman commented Jan 8, 2021

This is for kubernetes/enhancements#542 (issue description links back to this PR)

I think it's good to keep the e2e test to ensure that the new stable behaviour doesn't regress?

/lgtm

@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jan 8, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2021
@ehashman ehashman mentioned this pull request Jan 13, 2021
Merged
13 tasks
@wawa0210
Copy link
Contributor Author

/assign @dims

@dims
Copy link
Member

dims commented Jan 14, 2021

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pacoxu, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8cefa49 into kubernetes:master Jan 14, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Mar 27, 2021
@pacoxu pacoxu mentioned this pull request Aug 6, 2021
Merged
13 tasks
@tossmilestone
Copy link
Member

tossmilestone commented Oct 8, 2021 •
edited

@wawa0210 This PR is a big change and will impact many controller-based application, the release-note description is too short and didn't not describe the full impact. And the default 1y expiration is just like a timebomb!

@tossmilestone tossmilestone mentioned this pull request Oct 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dims dims

@ehashman ehashman

@quinton-hoole quinton-hoole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wawa0210 @k8s-ci-robot @pacoxu @ehashman @dims @tossmilestone @quinton-hoole