Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #97860: move all variables in sampleAndWaterMarkHistograms::innerSet #98432

Merged
merged 1 commit into from Jan 26, 2021
Merged

Automated cherry pick of #97860: move all variables in sampleAndWaterMarkHistograms::innerSet #98432

merged 1 commit into from Jan 26, 2021

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Jan 26, 2021 •
edited by liggitt

Cherry pick of #97860 on release-1.19.

#97860: move all variables in sampleAndWaterMarkHistograms::innerSet

Reason for cherry pick: Fixes #97685

Does this PR introduce a user-facing change?:

Fixes a performance regression in 1.19 on ARM architectures computing priority and fairness metrics

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 26, 2021
@tkashem
Copy link
Contributor Author

tkashem commented Jan 26, 2021

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 26, 2021
@tkashem
Copy link
Contributor Author

tkashem commented Jan 26, 2021

/assign @MikeSpreitzer @deads2k @lavalamp

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
@MikeSpreitzer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2021
@MikeSpreitzer
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 26, 2021
@MikeSpreitzer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 26, 2021
@tkashem
Copy link
Contributor Author

tkashem commented Jan 26, 2021

/retest

hasheddan
hasheddan approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tkashem parent PR merged to master 18 days ago so I am guessing this needs CP on 1.20 also?

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, MikeSpreitzer, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tkashem
Copy link
Contributor Author

tkashem commented Jan 26, 2021

@tkashem parent PR merged to master 18 days ago so I am guessing this needs CP on 1.20 also?

@hasheddan 1.20 cherry-pick has already merged - #97866

@hasheddan
Copy link
Contributor

@tkashem okay 👍 Please do your best to group cherry picks together when they need to go to multiple branches. This means the fix was in v1.20.2, but not v1.19.7, which went out the same day. Although from the context, it looks like it may not have been realized at the time that this was applicable to 1.19.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2021
@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 26, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3545719 into kubernetes:release-1.19 Jan 26, 2021
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeSpreitzer MikeSpreitzer MikeSpreitzer approved these changes

@hasheddan hasheddan hasheddan approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@lavalamp lavalamp

@deads2k deads2k

@MikeSpreitzer MikeSpreitzer

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tkashem @MikeSpreitzer @k8s-ci-robot @hasheddan @lavalamp @liggitt @deads2k