New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #107847: service REST: Call Decorator(old) on update path #107875
Automated cherry pick of #107847: service REST: Call Decorator(old) on update path #107875
Conversation
This is causing a bug when upgrading from older releases to 1.23 because of Service's maybe-too-clever default-on-read logic. Service depends on `Decorator()` to be called upon read, to back-populate old saved objects which do not have `.clusterIPs[]` set. This works on read, but the cache saves the pre-decorated type (as it is documented) In 1.23, this code was refactored and it seems some edge-case handling was inadvertently removed (I have not confirmed exactly what happened). Test by aojea
/assign @thockin |
/lgtm |
cc @kubernetes/release-managers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, saschagrunert, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #107847 on release-1.23.
#107847: service REST: Call Decorator(old) on update path
For details on the cherry pick process, see the cherry pick requests page.