Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements pod deletion cost #99163

Merged
merged 1 commit into from Mar 2, 2021
Merged

Implements pod deletion cost #99163

merged 1 commit into from Mar 2, 2021

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Feb 17, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implements pod deletion cost feature.

Which issue(s) this PR fixes:

Part of #45509 kubernetes/enhancements#2255

Special notes for your reviewer:

Does this PR introduce a user-facing change?

 `controller.kubernetes.io/pod-deletion-cost` annotation can be set to offer a hint on the cost of deleting a pod compared to other pods belonging to the same ReplicaSet. Pods with lower deletion cost are deleted first. This is an alpha feature.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/2255-pod-cost

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 17, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Feb 17, 2021

/assign @liggitt
/assign @janetkuo

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ahg-g
Copy link
Member Author

ahg-g commented Feb 17, 2021

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Feb 17, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Feb 17, 2021

/retest

@liggitt liggitt added this to the v1.21 milestone Feb 18, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2021
@ahg-g ahg-g force-pushed the ahg-pod-deletion branch 3 times, most recently from bae0777 to 0fa283b Compare February 22, 2021 17:16
@ahg-g
Copy link
Member Author

ahg-g commented Feb 22, 2021

/triage accepted
/priority important-soon

@ahg-g
Copy link
Member Author

ahg-g commented Feb 23, 2021

/retest

@ahg-g ahg-g mentioned this pull request Feb 26, 2021
Open
8 tasks
liggitt
liggitt reviewed Feb 27, 2021
View reviewed changes
pkg/apis/core/helper/helpers.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/validation.go Outdated Show resolved Hide resolved
@liggitt liggitt moved this from In progress to Changes requested in API Reviews Feb 27, 2021
@liggitt
Copy link
Member

liggitt commented Feb 27, 2021

/approve

go ahead and squash in the review commits

@liggitt liggitt moved this from Changes requested to API review completed, 1.21 in API Reviews Feb 27, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2021
@drbugfinder-work
Copy link

/retest

@ahg-g
Copy link
Member Author

ahg-g commented Mar 1, 2021

/approve

go ahead and squash in the review commits

done.

@liggitt
Copy link
Member

liggitt commented Mar 1, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahg-g
Copy link
Member Author

ahg-g commented Mar 1, 2021

rebased and resolve a conflict in one of the build files.

@liggitt
Copy link
Member

liggitt commented Mar 1, 2021

/lgtm

@ahg-g
Copy link
Member Author

ahg-g commented Mar 1, 2021

/retest

1 similar comment
@ahg-g
Copy link
Member Author

ahg-g commented Mar 2, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@ahg-g: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-unit d7e80ab link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ahg-g
Copy link
Member Author

ahg-g commented Mar 2, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2e055da into kubernetes:master Mar 2, 2021
@Lion-Wei Lion-Wei mentioned this pull request Mar 3, 2021
Closed
@Lion-Wei
Copy link

Lion-Wei commented Mar 3, 2021

Hi, I think not only replicaSets, jobs also need podDeletionCost, is there any reason that we are not doing this?

@denniszielke denniszielke mentioned this pull request Apr 3, 2021
Closed
@ahg-g ahg-g mentioned this pull request Jun 28, 2021
Closed
@ahg-g ahg-g deleted the ahg-pod-deletion branch October 25, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@justinsb justinsb Awaiting requested review from justinsb

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@liggitt liggitt

@janetkuo janetkuo

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.21
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ahg-g @fejta-bot @liggitt @drbugfinder-work @k8s-ci-robot @Lion-Wei @wojtek-t @janetkuo