Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #99378 #103747

Merged
merged 3 commits into from Jul 20, 2021
Merged

Revert #99378 #103747

merged 3 commits into from Jul 20, 2021

Conversation

mattcary
Copy link
Contributor

/kind bug

Fixes #103727

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Revert addition of Add PersistentVolumeClaimDeletePoilcy to StatefulSet API.

@mattcary
Revert "Add StatefulSetAutoDeletePVC feature gate"
fb5b966 
This reverts commit 0feba0c.
@mattcary
Revert "statefulset PersistentVolumeClaimDeletePolicy api change"
10a3cc8 
This reverts commit e4e735c.

Change-Id: I3e17aa585fd9ae4f9e74b97326ae6b9fadd2a94c
@mattcary
Revert "tests for statefulset PersistentVolumeClaimDeletePolicy api c…
aeb8224 
…hange"

This reverts commit b259686.

Change-Id: I25cc8ae8a9aa77d0bc483147d3f8fb65616a2b2b
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 16, 2021
@mattcary
Copy link
Contributor Author

/sig api-machinery
/sig apps

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 16, 2021
@mattcary
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 16, 2021
@mattcary
Copy link
Contributor Author

/assign @smarterclayton

@mattcary
Copy link
Contributor Author

/cc @kikisdeliveryservice

@kikisdeliveryservice
Copy link
Member

/assign @liggitt

@kikisdeliveryservice
Copy link
Member

/assign @lavalamp

@kikisdeliveryservice
Copy link
Member

Original PR for ref: #99378

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@lavalamp
Copy link
Member

I don't have time to review, but here is an

/approve

since I assume this is blocking the release.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
@kikisdeliveryservice
Copy link
Member

Hi all, can we please get final reviews on this?

@liggitt
Copy link
Member

liggitt commented Jul 20, 2021

/milestone v1.22
/lgtm

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 20, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7303b2c into kubernetes:master Jul 20, 2021
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 20, 2021
@tengqm tengqm mentioned this pull request Jul 23, 2021
Merged
@mattcary mattcary mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@lavalamp lavalamp

@liggitt liggitt

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Revert #99378, StatefulSet autodelete API changes
8 participants
@mattcary @kikisdeliveryservice @fejta-bot @lavalamp @k8s-ci-robot @liggitt @fedebongio @smarterclayton