Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick #96876 in controller to 1.18: fix nodelifecyle controller not add NoExecute taint bug #98943

Merged
merged 1 commit into from Mar 5, 2021
Merged

Cherry pick #96876 in controller to 1.18: fix nodelifecyle controller not add NoExecute taint bug #98943

merged 1 commit into from Mar 5, 2021

Conversation

CKchen0726
Copy link
Contributor

@CKchen0726 CKchen0726 commented Feb 10, 2021 •
edited by liggitt

What type of PR is this?
/kind bug

What this PR does / why we need it:
this PR #89059 try to fix reconcile problem, so every 5s monitorNodeHealth() run processTaintBaseEviction(), add nodes to zoneNoExecuteTainter cause these nodes' status is Unknown or False.
Ref: #96876

Which issue(s) this PR fixes:
Fix: #94183 #96183

Special notes for your reviewer:
I write a helper func to print values inside RateLimitedTimedQueue, and unit test running log as below, and log display the dirty data inside queue field.

Does this PR introduce a user-facing change?

fixing a bug where a failed node may not have the NoExecute taint set correctly

@k8s-ci-robot @CKchen0726
Merge pull request kubernetes#96876 from howieyuen/no-execute-taint-m…
88457be 
…issing

fix nodelifecyle controller not add NoExecute taint bug
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 10, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @CKchen0726. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 10, 2021
@JornShen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2021
@CKchen0726
Copy link
Contributor Author

/retest

hasheddan
hasheddan reviewed Feb 12, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @k82cn
/retest

Could you take a look here? Same CP that you approved for 1.19 #98140

@liggitt
Copy link
Member

liggitt commented Feb 23, 2021

/sig node
/cc @derekwaynecarr
as original PR reviewer/approver

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 23, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Feb 23, 2021
ehashman
ehashman approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/priority important-soon
/triage accepted
/lgtm

I'm going to try to get all three branches lined up.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 23, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2021
@ehashman ehashman moved this from Triage to Needs Approver in SIG Node PR Triage Feb 23, 2021
@ehashman
Copy link
Member

Note to reviewer: while this is done in one commit, the reason the diff doesn't match #96876 is because this is a double backport of #89059 (landed in 1.19) and then #96876.

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@derekwaynecarr derekwaynecarr moved this from Needs Approver to Done in SIG Node PR Triage Mar 4, 2021
@LuckySB
Copy link

LuckySB commented Mar 5, 2021

@hasheddan can you add cherry-pick-approved label ?

hasheddan
hasheddan approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CKchen0726, derekwaynecarr, ehashman, hasheddan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit adbe98a into kubernetes:release-1.18 Mar 5, 2021
@gjkim42 gjkim42 mentioned this pull request May 15, 2021
Closed
@CKchen0726 CKchen0726 deleted the cherry-pick-96876-1.18 branch October 25, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman approved these changes

@hasheddan hasheddan hasheddan approved these changes

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@k82cn k82cn Awaiting requested review from k82cn

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@ehashman ehashman

@derekwaynecarr derekwaynecarr

@k82cn k82cn

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@CKchen0726 @k8s-ci-robot @JornShen @liggitt @ehashman @derekwaynecarr @LuckySB @hasheddan @k82cn