Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scheduler] Remove deprecated volumeSchedulingLatency metric #104518

Merged
merged 1 commit into from Aug 25, 2021
Merged

[scheduler] Remove deprecated volumeSchedulingLatency metric #104518

merged 1 commit into from Aug 25, 2021

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Aug 23, 2021 •
edited

As part of #100720 we backported fix on existing releases and
in this commit we completely remove the deprecated metric from the master branch.

Signed-off-by: dntosas ntosas@gmail.com

What type of PR is this?

/kind cleanup
/kind deprecation

Does this PR introduce a user-facing change?

Removed deprecated metric `scheduler_volume_scheduling_duration_seconds`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 23, 2021
@k8s-ci-robot
Copy link
Contributor

@dntosas: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 23, 2021
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 23, 2021
binacs
binacs suggested changes Aug 23, 2021
View reviewed changes
pkg/scheduler/framework/plugins/volumebinding/binder.go Outdated
@@ -378,7 +377,7 @@ func (b *volumeBinder) AssumePodVolumes(assumedPod *v1.Pod, nodeName string, pod
klog.V(4).Infof("AssumePodVolumes for pod %q, node %q", podName, nodeName)
start := time.Now()
defer func() {
metrics.VolumeSchedulingStageLatency.WithLabelValues("assume").Observe(time.Since(start).Seconds())
metrics..WithLabelValues("assume").Observe(time.Since(start).Seconds())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metrics..WithLabelValues is illegal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg, wrong delete shortcut 😋 thanks ^

pkg/scheduler/framework/plugins/volumebinding/binder.go Outdated Show resolved Hide resolved
@dntosas dntosas force-pushed the scheduler-remove-deprecated-metric branch from a8701cd to 9f6d18d Compare August 23, 2021 11:54
binacs
binacs reviewed Aug 23, 2021
View reviewed changes
Copy link
Member

@binacs binacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2021
@binacs
Copy link
Member

binacs commented Aug 23, 2021 

+ go install ./cmd/...
# k8s.io/kubernetes/pkg/scheduler/framework/plugins/volumebinding
pkg/scheduler/framework/plugins/volumebinding/binder.go:293:2: start declared but not used
pkg/scheduler/framework/plugins/volumebinding/binder.go:378:2: start declared but not used
pkg/scheduler/framework/plugins/volumebinding/binder.go:451:2: start declared but not used

@dntosas please remove unused start := time.Now().

@dntosas
[scheduler] Remove deprecated volumeSchedulingLatency metric
cd795fa 
As part of kubernetes#100720 we
backported fix on existing releases and in this commit we completely
remove the deprecated metric from master branch.

Signed-off-by: dntosas <ntosas@gmail.com>
@dntosas dntosas force-pushed the scheduler-remove-deprecated-metric branch from 9f6d18d to cd795fa Compare August 23, 2021 12:20
@msau42
Copy link
Member

msau42 commented Aug 24, 2021

Can you modify your release note with the full metric name scheduler_volume_scheduling_duration_seconds?

/hold
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dntosas, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
@dntosas
Copy link
Contributor Author

dntosas commented Aug 24, 2021

Can you modify your release note with the full metric name scheduler_volume_scheduling_duration_seconds?

/hold
/lgtm
/approve

sure, done ^^

@msau42
Copy link
Member

msau42 commented Aug 24, 2021

Thanks!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@pacoxu
Copy link
Member

pacoxu commented Aug 25, 2021

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@dntosas
Copy link
Contributor Author

dntosas commented Aug 25, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 296991f into kubernetes:master Aug 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 25, 2021
@liggitt
Copy link
Member

liggitt commented Nov 22, 2021 •
edited

is there an alternative metric consumers should switch to? can that be indicated in the release note?

@msau42
Copy link
Member

msau42 commented Nov 22, 2021

plugin_execution_duration_seconds can be used with plugin=VolumeBinding

@dntosas dntosas mentioned this pull request Oct 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binacs binacs binacs requested changes

@humblec humblec Awaiting requested review from humblec

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dntosas @k8s-ci-robot @binacs @msau42 @pacoxu @k8s-triage-robot @liggitt