Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: promote DualStack feature gate to Beta #99294

Merged
merged 1 commit into from Feb 26, 2021
Merged

kubeadm: promote DualStack feature gate to Beta #99294

merged 1 commit into from Feb 26, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Feb 22, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

upgrade IPv6DualStack feature to beta and turn on by default for kubeadm

Which issue(s) this PR fixes:

Part of kubernetes/kubeadm#1612

Special notes for your reviewer:

Since #98969 is merged.

Does this PR introduce a user-facing change?

kubeadm: promote IPv6DualStack feature gate to Beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/563-dual-stack

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2021
@pacoxu pacoxu mentioned this pull request Feb 22, 2021
Closed
14 tasks
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2021
neolit123
neolit123 reviewed Feb 22, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/priority important-longterm
/triage accepted

this seems fine for me since it has been alpha for a while and the core PR is merging.
a couple of Qs:

  • @pacoxu i know that you wanted to send a documentation update for dual stack example setup with kubeadm, ideally we should send that PR first before merging this.
  • @aojea do you know if we have dual-stack e2e tests already e.g. with kind (cc @Arvinderpal )

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 22, 2021
@neolit123 neolit123 mentioned this pull request Feb 22, 2021
Merged
@aojea
Copy link
Member

aojea commented Feb 22, 2021

  • @aojea do you know if we have dual-stack e2e tests already e.g. with kind (cc @Arvinderpal )

we do for iptables and ipvs
https://testgrid.k8s.io/sig-network-kind#sig-network-kind,%20dual,%20master

The goal is to have dualstack officially in kind, once it happens I plan to work on adding presubmit jobs with dual-stack

@pacoxu
Copy link
Member Author

pacoxu commented Feb 24, 2021

@neolit123
I am working on kubernetes/website#26675 for dual-stack installation guide via kubeadm documentation.

@reylejano reylejano mentioned this pull request Feb 26, 2021
Merged
8 tasks
@neolit123
Copy link
Member

/lgtm
/approve
thanks @aojea @pacoxu

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Feb 26, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1ddc4af into kubernetes:master Feb 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 26, 2021
@pacoxu pacoxu mentioned this pull request Mar 3, 2021
Merged
@aojea aojea mentioned this pull request Apr 1, 2021
Merged
@pacoxu pacoxu deleted the kubeadm/dual-stack branch June 23, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@yagonobre yagonobre Awaiting requested review from yagonobre

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacoxu @aojea @neolit123 @k8s-ci-robot