Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve IP addresses of host-only in filtered dialer #98436

Merged
merged 1 commit into from Jan 27, 2021
Merged

Resolve IP addresses of host-only in filtered dialer #98436

merged 1 commit into from Jan 27, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 26, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

The filtered dialer introduced in 1.20 in #91785 / #95206 does not correctly wire the args passed to DialContext and the arg passed to LookupIPAddr. DialContext expects host:port. LookupIPAddr expects only host.

This PR fixes that issue and adds unit tests.

Does this PR introduce a user-facing change?:

Fixes a regression in 1.20 with connection errors when using `--volume-host-cidr-denylist` or `--volume-host-allow-local-loopback`

/cc @mattcary
/sig storage

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 26, 2021
@k8s-ci-robot
Copy link
Contributor

@liggitt: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 26, 2021
@liggitt liggitt mentioned this pull request Jan 26, 2021
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jan 26, 2021
@liggitt liggitt mentioned this pull request Jan 26, 2021
Merged
@mattcary
Copy link
Contributor

/lgtm

Thanks for finding this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2021
@liggitt
Copy link
Member Author

liggitt commented Jan 26, 2021

/hold

would like to verify this resolves the failures using the filtered dialer in #97934 before merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2021
@liggitt
Copy link
Member Author

liggitt commented Jan 26, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4fc184f into kubernetes:master Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 27, 2021
aojea
aojea reviewed Jan 28, 2021
View reviewed changes
pkg/proxy/util/utils.go
addressToResolve = address
}

resp, err := resolv.LookupIPAddr(ctx, addressToResolve)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can return multiple IP families

// LookupIPAddr looks up host using the local resolver.
// It returns a slice of that host's IPv4 and IPv6 addresses.
func (r *Resolver) LookupIPAddr(ctx context.Context, host string) ([]IPAddr, error) {
return r.lookupIPAddr(ctx, "ip", host)
}

🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, this filter just makes sure they all comply with the requirements (no local loopback, or nothing in a forbidden CIDR range)

k8s-ci-robot added a commit that referenced this pull request Jan 29, 2021
@k8s-ci-robot
Merge pull request #98438 from liggitt/automated-cherry-pick-of-#9843…
4dd99b3 
…6-upstream-release-1.20

Automated cherry pick of #98436: Resolve IP addresses of host-only in filtered dialer
@liggitt liggitt deleted the filtered-proxy branch February 2, 2021 13:23
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@mattcary mattcary Awaiting requested review from mattcary

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @mattcary @aojea