Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.19][go1.15] Update to go1.15.8 #99093

Merged
merged 5 commits into from Feb 16, 2021
Merged

[1.19][go1.15] Update to go1.15.8 #99093

merged 5 commits into from Feb 16, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 15, 2021

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

  • Update to go1.15.8

Tracking issue: kubernetes/release#1895
Slack thread: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1612545791171200

/assign @justaugustus
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- Kubernetes is now built using go1.15.8

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 15, 2021
@cpanato
Copy link
Member Author

cpanato commented Feb 15, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/provider/gcp Issues or PRs related to gcp provider and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2021
@cpanato cpanato mentioned this pull request Feb 15, 2021
Closed
20 tasks
@cpanato
Update to go1.15.8
9370942 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato cpanato force-pushed the automated-cherry-pick-of-#98834-upstream-release-1.19 branch from c1b5b0e to 64631ac Compare February 15, 2021 13:39
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 15, 2021
@cpanato
Copy link
Member Author

cpanato commented Feb 15, 2021

/test pull-kubernetes-verify

@cpanato
Copy link
Member Author

cpanato commented Feb 15, 2021

/retest

@cpanato
Copy link
Member Author

cpanato commented Feb 15, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@cpanato cpanato mentioned this pull request Feb 15, 2021
Merged
@cpanato cpanato force-pushed the automated-cherry-pick-of-#98834-upstream-release-1.19 branch from 64631ac to a82c063 Compare February 15, 2021 20:40
@cpanato
Copy link
Member Author

cpanato commented Feb 16, 2021

/retest

@justaugustus
Copy link
Member

/lgtm
/approve
/priority critical-urgent
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 16, 2021
@justaugustus justaugustus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 16, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 16, 2021
@justaugustus
Copy link
Member

/assign @dims

@cpanato
Copy link
Member Author

cpanato commented Feb 16, 2021

/assign @mkumatag

mkumatag
mkumatag approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@dims
Copy link
Member

dims commented Feb 16, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2fffed1 into kubernetes:release-1.19 Feb 16, 2021
@cpanato cpanato deleted the automated-cherry-pick-of-#98834-upstream-release-1.19 branch February 16, 2021 13:33
@liggitt
Copy link
Member

liggitt commented Feb 16, 2021

belated lgtm, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@dims dims Awaiting requested review from dims

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@dims dims

@justaugustus justaugustus

@liggitt liggitt

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cpanato @justaugustus @dims @k8s-ci-robot @liggitt @mkumatag