New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EndPort to Network Policy - Alpha #97058
Conversation
Skipping CI for Draft Pull Request. |
@rikatz: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig network |
/uncc @danwinship @resouer |
/cc @abhiraut I'm going to insert the feature gate and the validations during this week, when this is ready I'll convert from Draft to a valid PR |
So far:
Still needs:
|
OVS-CNI is some weird kubevirt thing. The plugins I'm involved with are openshift-sdn and ovn-kubernetes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's WIP but I was here...
staging/src/k8s.io/api/testdata/HEAD/extensions.v1beta1.NetworkPolicy.json
Show resolved
Hide resolved
5013d3e
to
eaeda9e
Compare
// This feature is in Alpha state and should be enabled using the Feature Gate | ||
// "NetworkPolicyEndPort". | ||
// +optional | ||
optional int32 endPort = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird curious what these =2
and =3
things mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nvm i guess thats the byte where they appear ha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits on 65535, but otherwise looks good to me sir !!!!!!!!!!!
@rikatz if my comments arent too important feel free to merge, your call :) |
/lgtm |
feel free to do the high port number in a follow on review @rikatz |
/hold |
wait we need to squash the commits ! |
ricardo said no squash required |
/hold remove |
he has the fancy label applied for this |
/hold cancel |
/retest |
@rikatz: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
how did /test pull-kubernetes-bazel-test fail but this merged? |
Yeah this is a mystery to me. Maybe it passed on the batch from tide but failed when I asked to retest |
BTW I recommend a tweak to the release note:
|
Thanks @sftim I've updated to contain only the field name (endPort), as now we already have this documented on website, sounds good? Otherwise can change again! :) |
Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it: This PR adds support to EndPort in Network Policy per Kep enhancements #2079 and the respective KEP (once it gets merged, will update the issue)
Which issue(s) this PR fixes:
Fixes #67526 #93111
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
TBD Docs
TODO: