Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containerd/console
base: v1.0.0
Choose a base ref
...
head repository: containerd/console
compare: v1.0.1
Choose a head ref
  • 18 commits
  • 192 files changed
  • 8 contributors

Commits on Jul 28, 2020

  1. Current: allow stdin to be redirected 

    In case we have stdin redirected, we still have a terminal which
can be obtained from stdout or stderr. This is what this commit
does.

This should allow something like this to work:

> ctr run --rm --tty docker.io/library/hello-world:latest xxx < /dev/null

NB: in case all three are redirected, but we still have a controlling
tty, we can easily get it by opening /dev/tty, but then it should be
closed, and it's not quite clear by whom and when, so this is left as
a home exersize for the reader.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Jul 28, 2020
    Copy the full SHA
    403f8bd View commit details
    Browse the repository at this point in the history

  2. travis: update to supported golang versions 

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Jul 28, 2020
    Copy the full SHA
    a8d4764 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Merge pull request #37 from kolyshkin/close-stdin 

    Current: allow stdin to be redirected
    @crosbymichael
    crosbymichael committed Jul 31, 2020
    Copy the full SHA
    a607003 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Update golang.org/x/sys/unix to v0.0.0-20200916030750-2334cc1a136f 

    Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
    @tklauser
    tklauser committed Sep 16, 2020
    Copy the full SHA
    2d4d237 View commit details
    Browse the repository at this point in the history

  2. Use IoctlSetPointerInt from golang.org/x/sys/unix 

    Use unix.IoctlSetPointerInt instead of manually implementing it. This
fixes the build on darwin where direct syscalls, i.e.
unix.Syscall(SYS_IOCTL, ...) are no longer allowed and exported as of
golang/sys@6fcdbc0

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
    @tklauser
    tklauser committed Sep 16, 2020
    Copy the full SHA
    22cf7f1 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #40 from tklauser/ioctl-darwin 

    Use IoctlSetPointerInt from golang.org/x/sys/unix
    @estesp
    estesp committed Sep 16, 2020
    Copy the full SHA
    1526a8e View commit details
    Browse the repository at this point in the history

  4. vendor: pkg/errors v0.9.1 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Sep 16, 2020
    Copy the full SHA
    6d5bf3a View commit details
    Browse the repository at this point in the history

  5. Enable Github Actions-based CI 

    Also add linting to CI and remove travis script entries that were no-ops
(there are no tests for other platforms so the extra `go test`
invocations with GOOS settings were not doing anything)

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
    @estesp
    estesp committed Sep 16, 2020
    Copy the full SHA
    a665cca View commit details
    Browse the repository at this point in the history

  6. Merge pull request #38 from thaJeztah/update_pkg_errors 

    vendor: pkg/errors v0.9.1
    @mikebrow
    mikebrow committed Sep 16, 2020
    Copy the full SHA
    58f5cdd View commit details
    Browse the repository at this point in the history

  7. Merge pull request #36 from estesp/gh-actions 

    Enable Github Actions-based CI
    @estesp
    estesp committed Sep 16, 2020
    Copy the full SHA
    a032f0d View commit details
    Browse the repository at this point in the history

  8. Fix actions to follow the model from other repos 

    Getting the golangci-lint package needs to be done with the gomod
method.

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
    @estesp
    estesp committed Sep 16, 2020
    Copy the full SHA
    cf8d0db View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Merge pull request #41 from estesp/fix-my-bad-actions 

    Fix actions to follow the model from other repos
    @estesp
    estesp committed Sep 17, 2020
    Copy the full SHA
    f847fbb View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Use Ioctl{SetPointerInt,GetInt} from golang.org/x/sys/unix on linux 

    Use unix.IoctlSetPointerInt and unix.IoctlGetInt instead of manually
implementing them. This avoid the use of the `unsafe` package.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
    @tklauser
    tklauser committed Sep 18, 2020
    Copy the full SHA
    f1b333f View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Remove travis configuration file 

    Now that we have GitHub actions running, the travis configuration
file should no longer be needed.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Sep 21, 2020
    Copy the full SHA
    15ccc45 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #43 from thaJeztah/remove_travis 

    Remove travis configuration file
    @mikebrow
    mikebrow committed Sep 21, 2020
    Copy the full SHA
    bc2a1bd View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Add support for NetBSD 

    Signed-off-by: Leonardo Taccari <leot@NetBSD.org>
    @iamleot
    iamleot committed Sep 22, 2020
    Copy the full SHA
    d96bce4 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #44 from iamleot/netbsd-support 

    Add support for NetBSD
    @estesp
    estesp committed Sep 22, 2020
    Copy the full SHA
    2f74731 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Merge pull request #42 from tklauser/linux-ioctl-x-sys-unix 

    Use Ioctl{SetPointerInt,GetInt} from golang.org/x/sys/unix on linux
    @estesp
    estesp committed Sep 24, 2020
    Copy the full SHA
    5d7e141 View commit details
    Browse the repository at this point in the history